Skip to content

Added the Debian os Part for Web2 ui. #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 7, 2016
Merged

Added the Debian os Part for Web2 ui. #16

merged 5 commits into from
Jul 7, 2016

Conversation

@tduemesnil
Copy link

Mainly a copy of the RedHat version which uses APT as Package Manager.
Added a Modified Path for the SQL Schema files.
Different Package for Debian

HTH
Thomas

@valentinogagliardi
Copy link
Contributor

Hello.
Would you check out the conflicts and modify the PR accordingly?
Thank you!

Thomas Duemesnil added 2 commits July 6, 2016 17:33
Merge remote-tracking branch 'upstream/master'
9dfdab9 
Change Var name to stay consistent with upstream
Variable name changed
3464f67
@tduemesnil
Copy link
Author

Hello.
I fixed the conflict in defaults and modified the var name to you new naming schema.

HTH

@valentinogagliardi
Copy link
Contributor

Thank you, I'm going to test that and I'll merge the PR when done.

@valentinogagliardi
Copy link
Contributor

I saw you placed login_user=root and login_pass={{ mysql_root_db_pass }} in icinga2-ansible-web2-ui/tasks/icinga2_web2_ui_Debian_install.yml. I think it'd better to omit that and let .my.cnf do the job as in the RH tasks. Starting on a fresh server, one could install MariaDB/Mysql, then install Icinga2 with UI and at the end runs mysql_secure_installation setting up the Mysql root password. Would you mind to remove login_user and login_pass? Apart from this the tasks works fine.
Thank you very much.

@tduemesnil
Copy link
Author

The mysql role (bennojoy.mysql) I use to setup the server immediately sets a root password. And creates a ~/.my.cnf file for the root user. Are the credentials use during the script ?

@valentinogagliardi
Copy link
Contributor

When the .my.cnf is already in place, there is no need to pass the credential to the tasks, Ansible automatically use .my.cnf

@tduemesnil
Copy link
Author

Always something to learn.

@icingaadmin icingaadmin merged commit 4b0948b into Icinga:master Jul 7, 2016
diegocarrion-wk pushed a commit to Workiva/icinga2-ansible that referenced this pull request May 7, 2019
@kareemstraker-wk @diegocarrion-wk
# This is a combination of 20 commits.
174645d 
# This is the 1st commit message:

add pinned versions for apt icinga

# This is the commit message #2:

reordering dependencies

# This is the commit message #3:

fix merge conflict 5500188

# This is the commit message #4:

remove duplicates, set final order

# This is the commit message #5:

updated descriptions and cleanup

# This is the commit message #6:

externalise icinga2_version

# This is the commit message #7:

update pyOpenSSL to be build on xenial

# This is the commit message #8:

add alternative way to add apt keys

# This is the commit message #9:

ignore errors

# This is the commit message Icinga#10:

update ubuntu install

# This is the commit message Icinga#11:

fix syntax

# This is the commit message Icinga#12:

try new urllib version

# This is the commit message Icinga#13:

remove urllib3 install

# This is the commit message Icinga#14:

use .com repos

# This is the commit message Icinga#15:

remove debmon stuff

# This is the commit message Icinga#16:

fix dependencies version pin

# This is the commit message Icinga#17:

remove replaced package

# This is the commit message Icinga#18:

pin another package

# This is the commit message Icinga#19:

undo change

# This is the commit message Icinga#20:

add icinga2-ido-mysql to pinned versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tduemesnil @valentinogagliardi @icingaadmin