Feature/new line between multi line property #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
privatenumber
commented
Jul 21, 2020
privatenumber
commented
- Pulled in upstream master
- Added the test-case
* feat: Add no-empty-component-block rule * chore: run update * feat: consider whether exist node.templateBody * refactor: use parserServices.getDocumentFragment * feat: consider whether exists context.parserServices.getDocumentFragment * feat: consider whitespaces and break lines * chore run update * refactor: reflect PR review
…#1226) * Fix scopeStack * Remove comma
…rops-destructure` and `vue/no-watch-after-await` (vuejs#1227)
…g-line-between-blocks` rules in `.js` file (vuejs#1232)
* changed tab to space in bug report template * remove space
* Remove jsx:true from shareable configs. * Fixed doc
* check '@vue/composition-api' usages in no-ref-as-operand * add test cases * add composition-api checking to no-lifecycle-after-await * add composition-api checking to no-watch-after-await * prettier fix * revert adding vue 2 support for async rules Co-authored-by: Yosuke Ota <[email protected]>
…vue/require-default-prop` and `vue/no-multiple-objects-in-class` rules crash on sparse arrays. (vuejs#1242)
* Chores: Remove eslint-plugin-vue-libs * update
* Supports Optional Chaining * Refactored to resemble eslint core util function naming. e.g. unwrap -> skip * update config * upgrade eslint-utils * Change the supported version of ESLint from 6.0.0 to 6.2.0.
- Change link to documentation to v3. - Add links to the v3 documentation in the rules for v3. - format.
…y-recommended`. (vuejs#1251) This is also recommended in the official guide. https://v3.vuejs.org/guide/component-custom-events.html#defining-custom-events
* Change the rules to support "v-is". - Change the `vue/attributes-order` rule to handle `v-is` as `DEFINITION` category. - Change the `vue/no-unregistered-components` rule to handle `v-is` like `:is`. - Change the `vue/no-unused-components` rule to handle `v-is` like `:is`. * Add `"v-is"` to the syntax checked by the `vue/no-unsupported-features` rule.
…nto feature/new-line-between-multi-line-property
privatenumber
commented
Jul 21, 2020
| a: { | ||
| propA: this.propA, | ||
| }, | ||
| b: null, |
There was a problem hiding this comment.
The error case adds a new line above this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.