Skip to content

Conversation

iangillingham-stfc
Copy link
Contributor

Description of work

User interface changes to support SCPI mode for Oxford Instruments Mercury IPS magnet controller.
Backward compatible with legacy mode via PV $(P):PROTOCOL.

This is part of an umbrella PR for IOC, support module, GUI and test framework changes.

Ticket

Link to Ticket

Acceptance criteria

Additional tabs, status and control fields available. This has been successfully reviewed and tested by Alex Jones.


Code Review

  • Is the code of an acceptable quality?
  • If the change is to an OPI, does the check_opi_format.py script in C:\Instrument\Dev\ibex_gui\base\uk.ac.stfc.isis.ibex.opis pass?
    The opi check does not pass, but the reasons are not valid in this case and not an error.
  • Do the changes function as described and is it robust?
  • Is there associated PR for the release notes?

Final Steps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant