Ticket8614 mercury ips magnet supply #1809
Open
+6,125
−273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
User interface changes to support SCPI mode for Oxford Instruments Mercury IPS magnet controller.
Backward compatible with legacy mode via PV $(P):PROTOCOL.
This is part of an umbrella PR for IOC, support module, GUI and test framework changes.
Ticket
Link to Ticket
Acceptance criteria
Additional tabs, status and control fields available. This has been successfully reviewed and tested by Alex Jones.
Code Review
check_opi_format.py
script in C:\Instrument\Dev\ibex_gui\base\uk.ac.stfc.isis.ibex.opis pass?The opi check does not pass, but the reasons are not valid in this case and not an error.
Final Steps