Skip to content

Fixed breaking change for checkstyle 8.42 #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −5
Open

Fixed breaking change for checkstyle 8.42 #1346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions base/uk.ac.stfc.isis.ibex.client.tycho.parent/checkstyle.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE module PUBLIC "-//Checkstyle//DTD Check Configuration 1.3//EN" "https://checkstyle.org/dtds/configuration_1_3.dtd">
<!DOCTYPE module PUBLIC "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN" "https://checkstyle.org/dtds/configuration_1_3.dtd">

<!--
This configuration file was written by the eclipse-cs plugin configuration editor
Expand All @@ -14,7 +14,7 @@
<module name="SuppressWarningsHolder"/>
<module name="ConstantName"/>
<module name="JavadocMethod">
<property name="scope" value="protected"/>
<property name="accessModifiers" value="protected, public"/>
</module>
<module name="JavadocType">
<property name="scope" value="protected"/>
Expand Down Expand Up @@ -68,9 +68,7 @@
<module name="EmptyStatement"/>
<module name="EqualsHashCode"/>
<module name="IllegalInstantiation"/>
<module name="MagicNumber">
<property name="constantWaiverParentToken" value="TYPECAST,METHOD_CALL,EXPR,ARRAY_INIT,UNARY_MINUS,UNARY_PLUS,ELIST,STAR,ASSIGN,PLUS,MINUS,DIV,LITERAL_NEW"/>
</module>
<module name="MagicNumber"/>
<module name="MissingSwitchDefault"/>
<module name="SimplifyBooleanExpression"/>
<module name="SimplifyBooleanReturn"/>
Expand All @@ -90,6 +88,9 @@
<module name="MissingJavadocType">
<property name="scope" value="package"/>
</module>
<module name="JavadocMethod">
<property name="accessModifiers" value="private"/>
</module>
</module>
<module name="SuppressWarningsFilter"/>
<module name="Translation"/>
Expand Down