ruff format + github action to check formatting #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlgrd
requested changes
Feb 7, 2025
Collaborator
wlgrd
left a comment
wlgrd
left a comment
There was a problem hiding this comment.
Agreeing that this should be put in to use :)
Author
|
Thanks for the feedback, should be alright now |
Tjoms99
changed the title
|
Any chance of this getting merged any time soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #51
Having a standard linter to format the code will mitigate unrelated formatting changes that IDE's use (VSCode as an example) when contributing to this codebase. This will help with keeping the repo clean and tidy.
All that is needed is to run
In the root directory before pushing to the repo.
Also added a github action to check the ruff formatting on every push.