Skip to content

Conversation

@Lance-Drane
Copy link
Collaborator

This MR adds functionality for services to listen to events for other services. It also provides an example for how to listen for these events (and makes sure that the example is integrated into the E2E tests, as always)

Closes #20

Signed-off-by: Lance Drane <[email protected]>
Copy link
Collaborator

@marshallmcdonnell marshallmcdonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!
I approve!

I only have one question just to check my understanding + comments where I really like the code!

Thank you!

assert run_example_test('4_service_to_service_events') == (
'From event "internal_service_event", received message "not_feeling_creative" from "example-organization.example-facility.example-system.example-subsystem.internal-service"\n'
'From event "internal_service_event", received message "not_feeling_creative" from "example-organization.example-facility.example-system.example-subsystem.internal-service"\n'
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"not_feeling_creative" 🤣

@Lance-Drane Lance-Drane merged commit 09d78f5 into main Feb 10, 2025
18 checks passed
@Lance-Drane Lance-Drane deleted the 20_svc2svc-events branch February 10, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow services to listen for events from other services

4 participants