Skip to content

Conversation

greglucas
Copy link
Collaborator

Use sizes instead as the deprecation warning suggests.

https://docs.xarray.dev/en/stable/whats-new.html#id38

Raise a FutureWarning warning that the type of Dataset.dims() will be changed from a mapping of dimension names to lengths to a set of dimension names. This is to increase consistency with DataArray.dims(). To access a mapping of dimension names to lengths please use Dataset.sizes(). The same change also applies to DatasetGroupBy.dims. (GH8496, PR8500) By Tom Nicholas.

Use sizes instead as the deprecation warning suggests.
@greglucas greglucas added Ins: MAG Related to the MAG instrument Repo: Testing Related to testing labels Mar 28, 2024
@greglucas greglucas requested a review from maxinelasp March 28, 2024 15:31
Copy link
Contributor

@maxinelasp maxinelasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do this in my current PR if that's easier, since I'm updating these tests anyway. Also, sorry for the delay, I didn't see this!

@greglucas
Copy link
Collaborator Author

I can do this in my current PR if that's easier, since I'm updating these tests anyway. Also, sorry for the delay, I didn't see this!

No, I much prefer smaller PRs to be merged in rather than continuing to add scope to other things, so lets keep this separate.

@maxinelasp let me know if you want me to merge this now or wait for yours. I have no idea if there will be conflicts, but I'm happy to rebase/update once you merge yours in if that is easier.

@maxinelasp
Copy link
Contributor

Go ahead and merge, I'll rebase it in :)

@greglucas greglucas merged commit ff30e4c into IMAP-Science-Operations-Center:dev Apr 2, 2024
@greglucas greglucas deleted the mag-deprecation branch April 2, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ins: MAG Related to the MAG instrument Repo: Testing Related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants