Skip to content

Conversation

@KumarGanesanIBM
Copy link
Contributor

PR summary

CIS & PDNS code changes for skipping integration test for other version except python 3.5.

Fixes: <! -- link to issue -->

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@KumarGanesanIBM KumarGanesanIBM self-assigned this Aug 3, 2020
@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #9 into master will increase coverage by 0.97%.
The diff coverage is 87.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   87.97%   88.94%   +0.97%     
==========================================
  Files          34       34              
  Lines        5879    17799   +11920     
==========================================
+ Hits         5172    15832   +10660     
- Misses        707     1967    +1260     
Impacted Files Coverage Δ
...m_cloud_networking_services/zone_rate_limits_v1.py 88.86% <ø> (-0.33%) ⬇️
ibm_cloud_networking_services/zones_settings_v1.py 87.28% <ø> (-4.26%) ⬇️
ibm_cloud_networking_services/zones_v1.py 89.20% <ø> (-2.72%) ⬇️
...oud_networking_services/global_load_balancer_v1.py 87.08% <85.63%> (-3.24%) ⬇️
ibm_cloud_networking_services/routing_v1.py 86.98% <85.71%> (-1.91%) ⬇️
...etworking_services/user_agent_blocking_rules_v1.py 87.64% <85.87%> (-3.27%) ⬇️
...loud_networking_services/ssl_certificate_api_v1.py 87.63% <85.92%> (-2.24%) ⬇️
ibm_cloud_networking_services/firewall_api_v1.py 86.72% <86.03%> (-1.96%) ⬇️
...ud_networking_services/firewall_access_rules_v1.py 88.65% <86.61%> (-2.58%) ⬇️
...tworking_services/zone_firewall_access_rules_v1.py 88.35% <86.61%> (-1.48%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8f8e04...c049615. Read the comment docs.

@KumarGanesanIBM KumarGanesanIBM merged commit c2ccca8 into master Aug 3, 2020
@ajay-malhotra1
Copy link
Contributor

🎉 This PR is included in version 0.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants