Skip to content

Conversation

@shivaleelac
Copy link
Contributor

@shivaleelac shivaleelac commented Aug 10, 2021

PR summary

Fixes: <! -- link to issue -->

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@shivaleelac shivaleelac requested review from DwitikrDash and KumarGanesanIBM and removed request for KumarGanesanIBM August 10, 2021 04:54
@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #33 (eb436e9) into master (bf0384b) will increase coverage by 0.57%.
The diff coverage is 93.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   88.01%   88.59%   +0.57%     
==========================================
  Files          37       37              
  Lines       22982    23773     +791     
==========================================
+ Hits        20227    21061     +834     
+ Misses       2755     2712      -43     
Impacted Files Coverage Δ
ibm_cloud_networking_services/dns_svcs_v1.py 92.31% <93.54%> (+4.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf0384b...eb436e9. Read the comment docs.

@shivaleelac shivaleelac changed the title feat(Custom Resolver):Added SDK for Custom Resolver feat(Custom Resolver):Added SDK for Custom Resolver, Import/Export Aug 10, 2021
@shivaleelac shivaleelac merged commit c08696e into master Aug 10, 2021
@shivaleelac shivaleelac changed the title feat(Custom Resolver):Added SDK for Custom Resolver, Import/Export feat(Custom Resolver): Added SDK for Custom Resolver, Import/Export Aug 11, 2021
@ajay-malhotra1
Copy link
Contributor

🎉 This PR is included in version 0.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants