Skip to content

Conversation

@DwitikrDash
Copy link

PR summary

Fixes: <! -- link to issue -->

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@DwitikrDash DwitikrDash requested review from MalarvizhiK and kennburger and removed request for kennburger June 22, 2021 04:40
@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #28 (c02137a) into master (87e6bf1) will increase coverage by 0.02%.
The diff coverage is 88.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   87.94%   87.97%   +0.02%     
==========================================
  Files          37       38       +1     
  Lines       22858    23517     +659     
==========================================
+ Hits        20103    20689     +586     
- Misses       2755     2828      +73     
Impacted Files Coverage Δ
ibm_cloud_networking_services/filters_v1.py 88.90% <88.90%> (ø)
ibm_cloud_networking_services/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87e6bf1...c02137a. Read the comment docs.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 88.92261% with 73 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.97%. Comparing base (87e6bf1) to head (c02137a).
⚠️ Report is 237 commits behind head on master.

Files with missing lines Patch % Lines
ibm_cloud_networking_services/filters_v1.py 88.90% 73 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   87.94%   87.97%   +0.02%     
==========================================
  Files          37       38       +1     
  Lines       22858    23517     +659     
==========================================
+ Hits        20103    20689     +586     
- Misses       2755     2828      +73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants