Skip to content

Conversation

@ajay-malhotra1
Copy link
Contributor

PR summary

Fixes: <! -- link to issue -->

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #24 (b80a289) into master (6f75b94) will increase coverage by 1.53%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   87.88%   89.42%   +1.53%     
==========================================
  Files          37       37              
  Lines       22265    22265              
==========================================
+ Hits        19568    19910     +342     
+ Misses       2697     2355     -342     
Impacted Files Coverage Δ
ibm_cloud_networking_services/common.py 100.00% <ø> (ø)
ibm_cloud_networking_services/zones_settings_v1.py 87.28% <0.00%> (+0.15%) ⬆️
ibm_cloud_networking_services/direct_link_v1.py 90.02% <0.00%> (+0.30%) ⬆️
...loud_networking_services/ssl_certificate_api_v1.py 87.50% <0.00%> (+0.53%) ⬆️
...m_cloud_networking_services/zone_rate_limits_v1.py 88.86% <0.00%> (+0.58%) ⬆️
...oud_networking_services/transit_gateway_apis_v1.py 90.99% <0.00%> (+0.75%) ⬆️
...ud_networking_services/firewall_access_rules_v1.py 88.65% <0.00%> (+0.96%) ⬆️
ibm_cloud_networking_services/caching_api_v1.py 90.18% <0.00%> (+0.99%) ⬆️
...tworking_services/global_load_balancer_pools_v0.py 90.38% <0.00%> (+1.00%) ⬆️
ibm_cloud_networking_services/zones_v1.py 89.20% <0.00%> (+1.07%) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f75b94...b80a289. Read the comment docs.

@ajay-malhotra1
Copy link
Contributor Author

@KumarGanesanIBM Can you please check these build errors

@ajay-malhotra1 ajay-malhotra1 merged commit e82ec1d into master Mar 12, 2021
@ajay-malhotra1 ajay-malhotra1 deleted the upg-python branch March 12, 2021 21:31
@ajay-malhotra1
Copy link
Contributor Author

🎉 This PR is included in version 0.4.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants