Skip to content

Conversation

@ajay-malhotra1
Copy link
Contributor

PR summary

deprecated the bgp_base_cidr in direct link

Fixes: <! -- link to issue -->

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #20 (d661dc5) into master (411d14d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   89.34%   89.35%   +0.01%     
==========================================
  Files          39       39              
  Lines       22050    22057       +7     
==========================================
+ Hits        19701    19710       +9     
+ Misses       2349     2347       -2     
Impacted Files Coverage Δ
ibm_cloud_networking_services/direct_link_v1.py 90.02% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 411d14d...d661dc5. Read the comment docs.

@ajay-malhotra1 ajay-malhotra1 merged commit d3c4c5c into master Nov 12, 2020
@ajay-malhotra1 ajay-malhotra1 deleted the dl-upd branch November 12, 2020 22:25
@ajay-malhotra1
Copy link
Contributor Author

🎉 This PR is included in version 0.3.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants