Detect secret #21
Merged
Detect secret #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ran detect-secrets Signed-off-by: Siddharth Mishra <[email protected]>
Signed-off-by: Siddharth Mishra <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 416 416
Branches 59 59
=========================================
Hits 416 416 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dinesh-venkatraman-g
approved these changes
Aug 18, 2022
4 tasks
Rishi-web
pushed a commit
to Rishi-web/keyprotect-nodejs-client
that referenced
this pull request
Oct 18, 2022
This reverts commit 0969a6c.
Rishi-web
pushed a commit
to Rishi-web/keyprotect-nodejs-client
that referenced
this pull request
Oct 18, 2022
This reverts commit 0969a6c. Signed-off-by: Rushil <[email protected]>
Rishi-web
pushed a commit
to Rishi-web/keyprotect-nodejs-client
that referenced
this pull request
Oct 18, 2022
This reverts commit 0969a6c.
Rishi-web
pushed a commit
to Rishi-web/keyprotect-nodejs-client
that referenced
this pull request
Oct 18, 2022
This reverts commit 0969a6c. Signed-off-by: Rushil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of “IBM Cloud 3Q2022: FS-IA readiness”, all the IBM/KMS repositories must enable “Detect Secrets” tool detect secrets, also scan and audit the secrets in their repositories before 8/21/2022.
In this PR I’ve enabled “detect-secrets” and also scanned and audited this repository. The results are in file .secrets.baseline.
I request that the team audit the potential secrets discovered in this scan.
Action taken as per PR:
For further info on detect-secrets please visit: https://w3.ibm.com/w3publisher/detect-secrets/developer-tool
FYI : Henry Grantham, Dinesh Venkatraman
Thanks