Update: Readme/Integration test case with key alias extension use cases #15
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 416 416
Branches 59 59
=========================================
Hits 416 416 Continue to review full report at Codecov.
|
Rishi-web
changed the title
|
|
|
|
|
|
||
| // wrap using key alias | ||
| const wrapKeyParams = Object.assign({}, options); | ||
| wrapKeyParams.id = createKeyAliasParams.alias; |
There was a problem hiding this comment.
We should not be setting alias to id.. instead, we should be able to set alias in input and perform the key action
|
|
||
| // un-wrap using key alias | ||
| const unwrapKeyParams = Object.assign({}, options); | ||
| unwrapKeyParams.id = createKeyAliasParams.alias; |
There was a problem hiding this comment.
We should not be setting alias to id.. instead, we should be able to set alias in input and perform the key action
|
|
||
| // delete a key using key alias | ||
| const deleteKeyParams = Object.assign({}, options); | ||
| deleteKeyParams.id = createKeyAliasParams.alias; |
There was a problem hiding this comment.
We should not be setting alias to id.. instead, we should be able to set alias in input and perform the key action
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #15 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 416 416
Branches 59 59
=========================================
Hits 416 416 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 participants
W.r.t issue - https://github.ibm.com/kms/kmk/issues/945
Key alias extension is tested for wrap/unwrap/delete key via nodejs SDK and a sample code for the same is updated in README.md file.