Skip to content

Conversation

@silpidhua
Copy link
Member

Renamed createInstanceHome to setInstanceHome

PR summary

Fixes: <! -- link to issue -->

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Renamed createInstanceHome to setInstanceHome
@silpidhua
Copy link
Member Author

silpidhua commented May 17, 2022

For the issue: https://github.ibm.com/hummingbird/tracker/issues/3441
Unit test result:

image

Integration test result:

image

Example test result:

image

image

image

image

Fixed lint error
@subinpc subinpc merged commit c2ad46c into silpi-3191-spark-history-server May 19, 2022
@subinpc subinpc deleted the 3441-silpi-createInstanceHome-setInstanceHome branch May 19, 2022 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants