fix(build): bump github.com/go-openapi/strfmt dependency
#257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Signed-off-by: Alex Mckenzie-Kelly <[email protected]> Signed-off-by: Alexander Mckenzie-Kelly <[email protected]>
pyrooka
requested changes
Oct 6, 2025
Member
pyrooka
left a comment
pyrooka
left a comment
There was a problem hiding this comment.
Thanks for the PR! One minor thing to change, otherwise it looks good.
| go 1.23.0 | ||
|
|
||
| toolchain go1.23.6 | ||
| go 1.24.0 |
Member
There was a problem hiding this comment.
Please revert this change. We'll update the Go versions in a separate PR in the near future, where we also update the Go versions used in the pipelines.
Member
Author
There was a problem hiding this comment.
@pyrooka thanks for the review - unfortunately the new module versions require 1.24, if I force it to 1.23 (via go mod edit -go=1.23) then gopls complains until I go mod tidy which brings it straight back.
I guess this fix has to wait on the Go version bump in that case.
pyrooka
changed the title
github.com/go-openapi/strfmt dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #256