Skip to content

Conversation

@jaksart1
Copy link
Contributor

PR summary

Added support for specific secret data types while updating and creating secrets, that are specific to each indivicual secret format.

Fixes: <! -- link to issue -->

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

JACK SARTORE and others added 9 commits March 23, 2023 17:37
* feat(oneOf): addeed type support for secret data types

BREAKING CHANGE: new classes for each secret data type added

* test fix

* test fix

* added more secret examples

* updated to latest openAPI, added oneOf for secret updates

* udpated timeout on int test

* increase timeout

* adjust timeout

* removed retries

* set retries to 0

* udpated retry interval

* sleep adjust

* removed loop, depending on python retry

* increased project sleep to 2 minutes before trying get

* moved sleep

* fixed timestamp name, will removed security alerts
# [3.0.0](https://github.ibm.com/coligo/python-sdk/compare/v2.0.3...v3.0.0) (2023-03-23)

### Features

* **oneOf:** addeed type support for secret data types ([#9](https://github.ibm.com/coligo/python-sdk/issues/9)) ([6dd33d2](https://github.ibm.com/coligo/python-sdk/commit/6dd33d2dca8663d65d00c4e5694bfa11abbb5d22))

### BREAKING CHANGES

* **oneOf:** new classes for each secret data type added

* test fix

* test fix

* added more secret examples

* updated to latest openAPI, added oneOf for secret updates

* udpated timeout on int test

* increase timeout

* adjust timeout

* removed retries

* set retries to 0

* udpated retry interval

* sleep adjust

* removed loop, depending on python retry

* increased project sleep to 2 minutes before trying get

* moved sleep

* fixed timestamp name, will removed security alerts
* fix(generator): SDK update 20230324-173405

* fix(api): added integration tests for egress ips

* fix(test): addressed linter violation
Signed-off-by: John Sartore <[email protected]>
…ing secrets, that are specific to each indivicual secret format.
@jaksart1 jaksart1 requested a review from reggeenr March 27, 2023 16:24
Copy link
Collaborator

@reggeenr reggeenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaksart1 jaksart1 merged commit 48f04cf into main Mar 27, 2023
@jaksart1 jaksart1 deleted the sdk-update-20230327-122344 branch March 27, 2023 16:29
jaksart1 pushed a commit that referenced this pull request Mar 27, 2023
* synced with latest python template

* added missing npmrc

* prepared v2 update of the python SDK

* feat(build): added v2 integration tests

* feat(test): added v2 integration tests

* adjusted python version

* fix(build) fixed linter warnings

* fix(build): adjusted travis config to trigger semantic release on push to main

* fix(build): adjusted semantic-release config (#5)

* feat(build): release v1 (#6)

BREAKING CHANGE: marks v1.0.0 of this repository

* Update version 0.1.0 -> 1.0.0

* chore(release): 1.0.0 release notes

# [1.0.0](https://github.ibm.com/coligo/python-sdk/compare/v0.1.0...v1.0.0) (2023-01-21)

### Features

* **build:** release v1 ([#6](https://github.ibm.com/coligo/python-sdk/issues/6)) ([160b7d1](https://github.ibm.com/coligo/python-sdk/commit/160b7d1ac4855a0eb7e6c534c2acb500fa65695f))

### BREAKING CHANGES

* **build:** marks v1.0.0 of this repository

* feat(ci): ready for v2 (#7)

BREAKING CHANGE: v2.0.0

* Update version 1.0.0 -> 2.0.0

* chore(release): 2.0.0 release notes

# [2.0.0](https://github.ibm.com/coligo/python-sdk/compare/v1.0.0...v2.0.0) (2023-01-24)

### Features

* **ci:** ready for v2 ([#7](https://github.ibm.com/coligo/python-sdk/issues/7)) ([b5eea13](https://github.ibm.com/coligo/python-sdk/commit/b5eea1399e835a3b913add7687e05ed376e87031))

### BREAKING CHANGES

* **ci:** v2.0.0

* fix(ci): added encrypted pypi deploy key (#8)

* Update version 2.0.0 -> 2.0.1

* chore(release): 2.0.1 release notes

## [2.0.1](https://github.ibm.com/coligo/python-sdk/compare/v2.0.0...v2.0.1) (2023-01-25)

### Bug Fixes

* **ci:** added encrypted pypi deploy key ([#8](https://github.ibm.com/coligo/python-sdk/issues/8)) ([729d82b](https://github.ibm.com/coligo/python-sdk/commit/729d82b3fb1bf8e0b550041451d05a3c1d78f80d))

* SDK update 20230125-144807

Co-authored-by: semantic-release-bot <[email protected]>
jaksart1 pushed a commit that referenced this pull request Mar 27, 2023
* synced with latest python template

* added missing npmrc

* prepared v2 update of the python SDK

* feat(build): added v2 integration tests

* feat(test): added v2 integration tests

* adjusted python version

* fix(build) fixed linter warnings

* fix(build): adjusted travis config to trigger semantic release on push to main

* fix(build): adjusted semantic-release config (#5)

* feat(build): release v1 (#6)

BREAKING CHANGE: marks v1.0.0 of this repository

* Update version 0.1.0 -> 1.0.0

* chore(release): 1.0.0 release notes

# [1.0.0](https://github.ibm.com/coligo/python-sdk/compare/v0.1.0...v1.0.0) (2023-01-21)

### Features

* **build:** release v1 ([#6](https://github.ibm.com/coligo/python-sdk/issues/6)) ([160b7d1](https://github.ibm.com/coligo/python-sdk/commit/160b7d1ac4855a0eb7e6c534c2acb500fa65695f))

### BREAKING CHANGES

* **build:** marks v1.0.0 of this repository

* feat(ci): ready for v2 (#7)

BREAKING CHANGE: v2.0.0

* Update version 1.0.0 -> 2.0.0

* chore(release): 2.0.0 release notes

# [2.0.0](https://github.ibm.com/coligo/python-sdk/compare/v1.0.0...v2.0.0) (2023-01-24)

### Features

* **ci:** ready for v2 ([#7](https://github.ibm.com/coligo/python-sdk/issues/7)) ([b5eea13](https://github.ibm.com/coligo/python-sdk/commit/b5eea1399e835a3b913add7687e05ed376e87031))

### BREAKING CHANGES

* **ci:** v2.0.0

* fix(ci): added encrypted pypi deploy key (#8)

* Update version 2.0.0 -> 2.0.1

* chore(release): 2.0.1 release notes

## [2.0.1](https://github.ibm.com/coligo/python-sdk/compare/v2.0.0...v2.0.1) (2023-01-25)

### Bug Fixes

* **ci:** added encrypted pypi deploy key ([#8](https://github.ibm.com/coligo/python-sdk/issues/8)) ([729d82b](https://github.ibm.com/coligo/python-sdk/commit/729d82b3fb1bf8e0b550041451d05a3c1d78f80d))

* fix(ci): adjusted branch configuration of travis

* Update version 2.0.1 -> 2.0.2

* chore(release): 2.0.2 release notes

## [2.0.2](https://github.ibm.com/coligo/python-sdk/compare/v2.0.1...v2.0.2) (2023-01-25)

### Bug Fixes

* **ci:** adjusted branch configuration of travis ([dc9e46e](https://github.ibm.com/coligo/python-sdk/commit/dc9e46e2eb4544f2af6e24d607309a422a801a66))

* SDK update 20230125-152037

* fix(build): fixed linter error which was caused by merge operation

Co-authored-by: semantic-release-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants