HBASE-29072 StochasticLoadBalancer#areReplicasColocated ignores rack colocation
#135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Map, rather than ordinal based indexing
rmdmattingly
commented
Jan 14, 2025
Comment on lines
-163
to
-164
| assertFalse(loadBalancer.needsBalance(HConstants.ENSEMBLE_TABLE_NAME, | ||
| new BalancerClusterState(map, null, null, new ForTestRackManagerOne()))); |
There was a problem hiding this comment.
This was just naively swapped to assertFalse in HBASE-26327 when we began ignoring rack colocation. The intention was originally for this case to be true
Comment on lines
150
to
157
| BalancerClusterState cluster = new BalancerClusterState(map, null, null, null); | ||
| loadBalancer.initCosts(cluster); | ||
| assertTrue(loadBalancer.needsBalance(HConstants.ENSEMBLE_TABLE_NAME, cluster)); | ||
| } | ||
|
|
||
| @Test | ||
| public void testNeedsBalanceForColocatedReplicasOnRack() { | ||
| // check for the case where there are two hosts and with one rack, and where |
There was a problem hiding this comment.
This is really two distinct tests that were previously in one method, so I've split it up.
rmdmattingly
force-pushed
the
HBASE-29072
branch
from
e2104a5 to
c9d2bbb
Compare
rmdmattingly
commented
Jan 14, 2025
Comment on lines
175
to
197
| @Test | ||
| public void testNoNeededBalanceForColocatedReplicasTooFewRacks() { | ||
| // Three hosts, two racks, and three replicas for a region. This cannot be balanced | ||
| List<RegionInfo> regions = randomRegions(1); | ||
| ServerName s1 = ServerName.valueOf("host1", 1000, 11111); | ||
| ServerName s2 = ServerName.valueOf("host11", 1000, 11111); | ||
| ServerName s3 = ServerName.valueOf("host2", 1000, 11111); | ||
| Map<ServerName, List<RegionInfo>> map = new HashMap<>(); | ||
| List<RegionInfo> regionsOnS2 = new ArrayList<>(1); | ||
| regionsOnS2.add(RegionReplicaUtil.getRegionInfoForReplica(regions.get(0), 1)); | ||
| map.put(s1, regions); | ||
| map.put(s2, regionsOnS2); | ||
| // there are 3 replicas for region 0, but only add a second rack | ||
| map.put(s3, ImmutableList.of(RegionReplicaUtil.getRegionInfoForReplica(regions.get(0), 2))); | ||
| BalancerClusterState cluster = new BalancerClusterState(map, null, null, null); | ||
| loadBalancer.initCosts(cluster); | ||
| // Should be false because there aren't enough racks | ||
| assertFalse(loadBalancer.needsBalance(HConstants.ENSEMBLE_TABLE_NAME, cluster)); | ||
| } |
There was a problem hiding this comment.
This new test validates our smarter way of deprioritizing rack balancing for topologies with too few racks.
rmdmattingly
force-pushed
the
HBASE-29072
branch
from
c9d2bbb to
f552bb9
Compare
rmdmattingly
force-pushed
the
HBASE-29072
branch
from
f552bb9 to
6e71102
Compare
rmdmattingly
force-pushed
the
HBASE-29071
branch
2 times, most recently
from
61bd05a to
b8ab794
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll rebase this PR to master when HBASE-29071 has shipped. This is yet another bite of apache#6593