Skip to content

Update 4-bad.js #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update 4-bad.js #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions JavaScript/4-bad.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
const poolify = (factory, options, size, max) => {
const instances = []; // Preallocate array
for (let i = 0; i < size; i++) { // Use Array methods instead of loop
// In this case destructuring will be optimized by V8
// https://github.com/v8/v8/blob/074bb97050edcb45ca33b250ebcb865279e61dd4/src/compiler/js-call-reducer.cc#L4542
// It will change function to direct ::Call() that is C++ function instead of creation of iterator
const instance = factory(...options); // Avoid array destructuring
instances.push(instance);
}
Expand Down