Skip to content

0.60 stable #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .ado/templates/apple-job-javascript.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ parameters:
apply_office_patches: ''

steps:
- script: 'brew update'
displayName: 'brew update'

- script: 'brew bundle'
displayName: 'brew bundle'

Expand Down
3 changes: 3 additions & 0 deletions .ado/templates/apple-job-react-native.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ steps:
rm -rf $(Build.Repository.LocalPath)/DerivedData
displayName: 'Clean DerivedData'

- script: 'brew update'
displayName: 'brew update'

# Install the required components specified in the Brewfile file.
- script: 'brew bundle'
displayName: 'brew bundle'
Expand Down
2 changes: 1 addition & 1 deletion React/Base/RCTPlatformDisplayLink.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@

#include <TargetConditionals.h>

#import <QuartzCore/CADisplayLink.h> // TODO GH#533, we need to explicitly pull in the framework to get the definition for CACurrentMediaTime()
#if !TARGET_OS_OSX
#import <QuartzCore/CADisplayLink.h>
#define RCTPlatformDisplayLink CADisplayLink
#else

Expand Down
6 changes: 4 additions & 2 deletions React/Views/RCTPicker.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,10 @@
@property (nonatomic, assign) NSInteger selectedIndex;

@property (nonatomic, strong) RCTUIColor *color; // TODO(OSS Candidate ISS#2710739)
@property (nonatomic, strong) UIFont *font;
@property (nonatomic, assign) NSTextAlignment textAlign;
#if !TARGET_OS_OSX // [TODO(macOS GH#533) // NSControl defines font prop for macOS, but iOS superviews don't
@property (nonatomic, strong) UIFont *font;
#endif // ]TODO(macOS GH#533)
@property (nonatomic, assign) NSTextAlignment textAlign;

@property (nonatomic, copy) RCTBubblingEventBlock onChange;

Expand Down
8 changes: 4 additions & 4 deletions React/Views/RCTPicker.m
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ - (instancetype)initWithFrame:(CGRect)frame
_color = [RCTUIColor blackColor]; // TODO(OSS Candidate ISS#2710739)
#if !TARGET_OS_OSX // TODO(macOS ISS#2323203)
_font = [UIFont systemFontOfSize:21]; // TODO: selected title default should be 23.5
#else // [TODO(macOS ISS#2323203)
_font = [UIFont systemFontOfSize:11];
#endif // ]TODO(macOS ISS#2323203)
#else // [TODO(macOS GH#533)
[self setFont:[NSFont systemFontOfSize:[NSFont systemFontSize]]];
#endif // ]TODO(macOS GH#533)
_selectedIndex = NSNotFound;
_textAlign = NSTextAlignmentCenter;
self.delegate = self;
Expand Down Expand Up @@ -63,7 +63,7 @@ - (void)setItems:(NSArray<NSDictionary *> *)items
NSMutableDictionary *mutableItem = item.mutableCopy;
NSAttributedString *attrString = [[NSAttributedString alloc] initWithString:[RCTConvert NSString:item[@"label"]]
attributes:@{NSForegroundColorAttributeName : [RCTConvert UIColor:item[@"textColor"]] ?: _color,
NSFontAttributeName: _font,
NSFontAttributeName: [self font] /* Use the font prop instead of the ivar so it's compatible on iOS and macOS TODO(OSS Candidate ISS#2710739) */,
NSParagraphStyleAttributeName: paragraphStyle}];
NSSize size = attrString.size;
if (size.height > maxHeight) {
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-native",
"version": "0.60.0-microsoft.91",
"version": "0.60.0-microsoft.93",
"description": "[Microsoft Fork] A framework for building native apps using React",
"license": "MIT",
"repository": {
Expand Down