Skip to content

Conversation

@HashimotoLogly
Copy link
Owner

OJTのレポート開発(view,click)を行いました。
主な開発内容は以下の通りです。

  • report アクションの追加
  • report.html.erbの追加
    • 広告を期間で絞るためのフォームを追加
  • advertiser_idの削除

Reportの結果を表示する開発に関しては午後より行なっていく予定です。

対応issue #8
 

Copy link

@tmk-hsn tmk-hsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コメントしたので確認をお願い!

def report
@report = Report.all
@ad = Ad.find(1)
p "afleihfjoiwahfoiawhgfoiahfoiaho"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

デバッグコード残ってる

@report = Report.all
@ad = Ad.find(1)
p "afleihfjoiwahfoiawhgfoiahfoiaho"
p @ad.class
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

デバッグコード残ってる


def report_period
@ads = Ad.all
@Report = Report.where(date: ( params[:date_min])..( params[:date_max]))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

変数の先頭は小文字にして

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paramsの前に不要なスペース

ActiveRecord::Schema.define(version: 2019_06_14_041856) do

create_table "ads", force: :cascade do |t|
t.integer "advertiser_id", null: false
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

テーブル定義は消して大丈夫?
広告を作成する時に広告主IDを指定しないだけで、広告主に広告が紐づく構造は変わらないから消したらマズイ気が

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すり合わせが必要とかだったら明日やろう


def report
@report = Report.all
@ad = Ad.find(1)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

質問:これってなんのためのアクションだっけ?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

report.htmlの表示を司るアクションです。只今試行錯誤中です...

Copy link

@tmk-hsn tmk-hsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants