Skip to content

Fixed duplicate results in YAML service name completion #1928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 10, 2022
Merged

Fixed duplicate results in YAML service name completion #1928

merged 2 commits into from
May 10, 2022

Conversation

adamwojs
Copy link
Contributor

@adamwojs adamwojs commented May 9, 2022 •
edited
Loading

Sorry, I overlooked this while testing #1919.

Due to missing fr.adrienbrault.idea.symfony2plugin.config.yaml.ServiceYamlReference#getVariants implementation results in YAML service name completion are duplicated.

image

TODO:

@adamwojs adamwojs force-pushed the duplicated_completion_fix branch 2 times, most recently from c75549b to 7a76919 Compare May 9, 2022 20:14
@Haehnchen
Copy link
Owner

👍

@Haehnchen Haehnchen merged commit e8e2fae into Haehnchen:master May 10, 2022
@adamwojs adamwojs deleted the duplicated_completion_fix branch May 10, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamwojs @Haehnchen