Skip to content

Conversation

@pavitrakumar78
Copy link

@pavitrakumar78 pavitrakumar78 commented Jan 9, 2017

added python 2.x compatibility
added workaround for breakout and space invaders to correct the number of moves
Note: this workaround just tells the acting methods that the move space will be 4 instead of the default 6. So, the network will be making a prediction amongst 0,1,2,3 which corresponds to ['NOOP', 'FIRE', 'RIGHT', 'LEFT'] - thus, we ignore the RIGHTFIRE and LEFTFIRE which are not needed for breakout.

added python 2.x compatibility
added workaround for breakout and space invaders to correct the number of moves
@Grzego
Copy link
Owner

Grzego commented Jan 14, 2017

I think it's useful to have Python 2 support but workarounds for action_space are not necessary. If you remove them I will merge this PR. Thanks! :)

removed workarounds for breakout and spaceinveders
@pavitrakumar78
Copy link
Author

That is just one line on the top! 👍
I removed the workarounds. You can test the code again if you want! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants