Add workaround for a Safari bug where our number input fields can't be released from click-and-drag #3053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build |
|
Keavon
changed the title
…oesnt fire automatically
Keavon
force-pushed
the
safari-drag-fix
branch
from
568edd4 to
28935a0
Compare
Keavon
approved these changes
Aug 19, 2025
Keavon
changed the title
Keavon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2038
I found a way to put a fallback into our
pointerUpconst (where we exit the pointerlock) to fire apointerLockChangeexplicitly when this event is not triggered automatically (in our case when using Safari).I've tested this on Safari, Firefox and Chrome and it seems this fallback both fixes/keeps the intended functionality without breaking the functionality of inputting per keyboard into the NumberInputs. Below a Safari demo.
Screen.Recording.2025-08-14.at.23.56.07.mov