Options bar widgets for tools to control tool behavior #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
d328dc8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://320d2a58.graphite-master.pages.dev |
TrueDoctor
reviewed
Jul 20, 2021
|
I can't really comment on the js but the rust looks fine so far. |
Closed
Keavon
reviewed
Jul 21, 2021
Keavon
approved these changes
Jul 21, 2021
Keavon
pushed a commit
that referenced
this pull request
Jun 16, 2022
* Add JSON-backed options widget * Add initial tool settings messaging to backend * Add shape side selection with JSON deserialization * Enforce minimum number of n-gon sides * Make tool settings JSON errors safer * Make tool settings JSON errors safer * Refactor ToolOptions to ToolSettings * Revert "Refactor ToolOptions to ToolSettings" This reverts commit 651161f. * Refactor all instances of "settings" to "options" * Fix names and formatting * Rearrange ToolOptions data to enforce types
Keavon
pushed a commit
that referenced
this pull request
Jul 30, 2023
* Add JSON-backed options widget * Add initial tool settings messaging to backend * Add shape side selection with JSON deserialization * Enforce minimum number of n-gon sides * Make tool settings JSON errors safer * Make tool settings JSON errors safer * Refactor ToolOptions to ToolSettings * Revert "Refactor ToolOptions to ToolSettings" This reverts commit 651161f. * Refactor all instances of "settings" to "options" * Fix names and formatting * Rearrange ToolOptions data to enforce types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #184
ToolOptionswidget that renders tool settings widgetsNumberInputitem within the options#284 documents the remaining work towards this feature. The tool option widgets will have to be connected to the backend through a standard messaging system, mapping each widget to a struct field or message (in the case of buttons).
This change is