Skip to content

Conversation

indierusty
Copy link
Collaborator

@indierusty indierusty commented Jun 7, 2025

Partly closes #2635

Copy link

github-actions bot commented Jun 7, 2025

Performance Benchmark Results

compile_demo_art_iai::compile_group::compile_to_proto with_setup_0:load_from_name(isometric-fountain)
Instructions: 25,052,666 (master) -> 25,030,307 (HEAD) : $$\color{lime}-0.09\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     310,437|    309,551          -0.29%
D1mw                      98,900|     98,583          -0.32%
DLmr                      28,669|     28,564          -0.37%
DLmw                      37,766|     32,996         -12.63%
Dr                     6,027,868|  6,020,974          -0.11%
Dw                     4,266,989|  4,263,797          -0.07%
EstimatedCycles       39,193,723| 39,008,250          -0.47%
I1mr                      47,523|     46,904          -1.30%
ILmr                         857|        874          +1.98%
Ir                    25,052,666| 25,030,307          -0.09%
L1hits                34,890,663| 34,860,040          -0.09%
LLhits                   389,568|    392,604          +0.78%
RamHits                   67,292|     62,434          -7.22%
TotalRW               35,347,523| 35,315,078          -0.09%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_1:load_from_name(painted-dreams)
Instructions: 12,246,243 (master) -> 12,256,438 (HEAD) : $$\color{red}+0.08\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     145,398|    145,425          +0.02%
D1mw                      46,876|     47,022          +0.31%
DLmr                         351|        299         -14.81%
DLmw                      14,994|     14,944          -0.33%
Dr                     2,946,112|  2,946,208          +0.00%
Dw                     2,077,337|  2,077,281          -0.00%
EstimatedCycles       18,608,890| 18,617,271          +0.05%
I1mr                      21,948|     22,099          +0.69%
ILmr                         732|        729          -0.41%
Ir                    12,246,243| 12,256,438          +0.08%
L1hits                17,055,470| 17,065,381          +0.06%
LLhits                   198,145|    198,574          +0.22%
RamHits                   16,077|     15,972          -0.65%
TotalRW               17,269,692| 17,279,927          +0.06%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_2:load_from_name(procedural-string-lights)
Instructions: 3,463,830 (master) -> 2,648,935 (HEAD) : $$\color{lime}-23.53\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                      40,436|     27,299         -32.49%
D1mw                      12,752|     12,427          -2.55%
DLmr                          19|         22         +15.79%
DLmw                       3,787|      2,601         -31.32%
Dr                       823,716|    609,033         -26.06%
Dw                       581,565|    445,385         -23.42%
EstimatedCycles        5,243,789|  3,987,741         -23.95%
I1mr                       6,454|      6,291          -2.53%
ILmr                         731|        721          -1.37%
Ir                     3,463,830|  2,648,935         -23.53%
L1hits                 4,809,469|  3,657,336         -23.96%
LLhits                    55,105|     42,673         -22.56%
RamHits                    4,537|      3,344         -26.29%
TotalRW                4,869,111|  3,703,353         -23.94%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_3:load_from_name(parametric-dunescape)
Instructions: 12,494,553 (master) -> 12,496,155 (HEAD) : $$\color{red}+0.01\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     152,856|    152,387          -0.31%
D1mw                      50,243|     50,430          +0.37%
DLmr                          42|         46          +9.52%
DLmw                      12,066|     12,163          +0.80%
Dr                     2,974,274|  2,972,820          -0.05%
Dw                     2,123,564|  2,123,223          -0.02%
EstimatedCycles       18,874,111| 18,877,700          +0.02%
I1mr                      20,101|     20,676          +2.86%
ILmr                         856|        842          -1.64%
Ir                    12,494,553| 12,496,155          +0.01%
L1hits                17,369,191| 17,368,705          -0.00%
LLhits                   210,236|    210,442          +0.10%
RamHits                   12,964|     13,051          +0.67%
TotalRW               17,592,391| 17,592,198          -0.00%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_4:load_from_name(red-dress)
Instructions: 29,986,178 (master) -> 29,982,589 (HEAD) : $$\color{lime}-0.01\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     382,664|    382,968          +0.08%
D1mw                     126,776|    127,061          +0.22%
DLmr                      40,772|     40,731          -0.10%
DLmw                      65,373|     63,865          -2.31%
Dr                     7,152,832|  7,152,929          +0.00%
Dw                     5,073,248|  5,073,208          -0.00%
EstimatedCycles       47,665,044| 47,618,184          -0.10%
I1mr                      51,249|     51,288          +0.08%
ILmr                         856|        877          +2.45%
Ir                    29,986,178| 29,982,589          -0.01%
L1hits                41,651,569| 41,647,409          -0.01%
LLhits                   453,688|    455,844          +0.48%
RamHits                  107,001|    105,473          -1.43%
TotalRW               42,212,258| 42,208,726          -0.01%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_5:load_from_name(valley-of-spires)
Instructions: 19,011,041 (master) -> 19,007,102 (HEAD) : $$\color{lime}-0.02\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     235,955|    235,398          -0.24%
D1mw                      76,715|     77,079          +0.47%
DLmr                      12,251|     12,201          -0.41%
DLmw                      28,492|     29,156          +2.33%
Dr                     4,559,188|  4,557,964          -0.03%
Dw                     3,228,463|  3,227,673          -0.02%
EstimatedCycles       29,435,208| 29,447,671          +0.04%
I1mr                      35,119|     35,266          +0.42%
ILmr                         769|        775          +0.78%
Ir                    19,011,041| 19,007,102          -0.02%
L1hits                26,450,903| 26,444,996          -0.02%
LLhits                   306,277|    305,611          -0.22%
RamHits                   41,512|     42,132          +1.49%
TotalRW               26,798,692| 26,792,739          -0.02%

@Keavon Keavon changed the title Refactor 'Morph' node to use Kurbo instead of Bezier-rs Refactor the 'Morph' node to use Kurbo instead of Bezier-rs Jun 8, 2025
@Keavon Keavon merged commit 269c572 into master Jun 8, 2025
4 checks passed
@Keavon Keavon deleted the ir/morph branch June 8, 2025 22:13
Keavon added a commit that referenced this pull request Jun 20, 2025
* fix morph node

* it worked!

* cleanup

* add comments

---------

Co-authored-by: Keavon Chambers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking Issue: Refactor nodes to use Kurbo instead of Bezier-rs
2 participants