-
-
Notifications
You must be signed in to change notification settings - Fork 975
Instance tables refactor part 7: reorganize raster data to remove TextureFrameTable #2693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…lor> with RasterDataTable<Color>
1081b36 to
1b4829d
Compare
Performance Benchmark Resultscompile_demo_art_iai::compile_group::compile_to_proto with_setup_0:load_from_name(isometric-fountain) Detailed metricscompile_demo_art_iai::compile_group::compile_to_proto with_setup_1:load_from_name(painted-dreams) Detailed metricscompile_demo_art_iai::compile_group::compile_to_proto with_setup_2:load_from_name(procedural-string-lights) Detailed metricscompile_demo_art_iai::compile_group::compile_to_proto with_setup_3:load_from_name(parametric-dunescape) Detailed metricscompile_demo_art_iai::compile_group::compile_to_proto with_setup_4:load_from_name(red-dress) Detailed metricscompile_demo_art_iai::compile_group::compile_to_proto with_setup_5:load_from_name(valley-of-spires) Detailed metrics |
…tureFrameTable (GraphiteEditor#2693) * Partial commit 1/3: Unwrap RasterFrame and replace ImageFrameTable<Color> with RasterDataTable<Color> * Partial commit 2/3: Removal of TextureFrameTable usages * Partial commit 3/3: Document upgrade code * Fix brush broken in part 6 * Re-save the demo artwork
…tureFrameTable (#2693) * Partial commit 1/3: Unwrap RasterFrame and replace ImageFrameTable<Color> with RasterDataTable<Color> * Partial commit 2/3: Removal of TextureFrameTable usages * Partial commit 3/3: Document upgrade code * Fix brush broken in part 6 * Re-save the demo artwork
This merged PR was removed in a history rewrite of master, and replaced by:
This splits up the rename (5cacab2) from the logic changes (6111440) and replaces the logic changes from what was originally landed in this PR. This PR's removal of texture was undone, and instead the texture was retained but moved to the
Rasterstruct with CPU and GPU textures, both assigned as variants toGraphicElementnow. The old PR description is below.Partly closes #1834
ImageFrameTable<Color>RasterDataTable<Color>ImageFrameTable<SRGBA8>RasterDataTable<SRGBA8>TaggedValue::ImageFrame(ImageFrameTable<Color>)TaggedValue::RasterData(RasterDataTable<Color>)GraphicElement::RasterFrameGraphicElement::RasterDatapub enum RasterFrame {ImageFrame(ImageFrameTable<Color>),TextureFrame(TextureFrameTable),}But replaced with the temporarily unused:
pub enum RasterTexture {Image(Image<Color>),Texture(ImageTexture),}pub type TextureFrameTable = Instances<ImageTexture>;