Replace Instances<T>::empty() with Instances<T>::default() and make it return an empty table for vector data instead of one empty row #2689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en vector, and replace ::empty() with ::default()
Keavon
force-pushed
the
default-empty-vector-tables
branch
from
3c627ca to
7e4bf1d
Compare
9 tasks
Keavon
changed the title
seam0s-dev
pushed a commit
to seam0s-dev/Graphite
that referenced
this pull request
Jun 8, 2025
…t return an empty table for vector data instead of one empty row (GraphiteEditor#2689) Make Instances<T>::default() return an empty table for everything, even vector, and replace ::empty() with ::default()
mTvare6
pushed a commit
that referenced
this pull request
Jun 8, 2025
…t return an empty table for vector data instead of one empty row (#2689) Make Instances<T>::default() return an empty table for everything, even vector, and replace ::empty() with ::default()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final cleanup for part 6, closes #1834.
This PR introduces this regression: #2688.