-
-
Notifications
You must be signed in to change notification settings - Fork 976
Instance tables refactor part 5: unwrap GraphicGroup as multi-row Instance<GraphicElement> tables and move up transforms #2363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Member
|
Only very few because we can use the automated edition upgrade on this pr as well. that should resolve most of the conficts - Edit wrong pr, meant to comment on #2367 |
439d9b5 to
64b3683
Compare
f9dbbc7 to
8684636
Compare
64e3d1c to
e1a6ffa
Compare
ac7bbf9 to
b220693
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 5, partly closes #1834.
Discussion about squashing some bugs (for the record): https://discord.com/channels/731730685944922173/860830913390575646/1348437590914895893
Issues
All leaf nodes are incorrectly being grouped, with their transform and alpha blending being applied to that group instead of the direct leaf SVG element (deferred for after part 6 or 7)
Transform nodes mess up stroke transforms
Empty vectordata: there was a default empty vectordata in all groups.
Transforming a group with the tools resets the transform to identity.
We need to have an original transform when using tooling e.g. grs. We use
GraphOperationMessage::TransformSetwith the values stored inOriginalTransforms. This allows us to stop the transform being stuck at zero when the user drags the bounds through zero.We also need a local transform for orientating the bounding box.
What is the original transform for a group?
If you apply a transform node to the left of a group, it actually just transforms all of the elements in the group.
If you apply a transform node above the group, it will also transform other layers which we don't want.