Skip to content

Conversation

@Keavon
Copy link
Member

@Keavon Keavon commented Mar 5, 2025

Part 5, partly closes #1834.

Discussion about squashing some bugs (for the record): https://discord.com/channels/731730685944922173/860830913390575646/1348437590914895893

Issues

  • All leaf nodes are incorrectly being grouped, with their transform and alpha blending being applied to that group instead of the direct leaf SVG element (deferred for after part 6 or 7)

    • Fix for Vello as well (if necessary), and test Vello in general (deferred for after part 6 or 7)
  • Transform nodes mess up stroke transforms

  • Empty vectordata: there was a default empty vectordata in all groups.

  • Transforming a group with the tools resets the transform to identity.
    We need to have an original transform when using tooling e.g. grs. We use GraphOperationMessage::TransformSet with the values stored in OriginalTransforms. This allows us to stop the transform being stuck at zero when the user drags the bounds through zero.
    We also need a local transform for orientating the bounding box.

  • What is the original transform for a group?
    If you apply a transform node to the left of a group, it actually just transforms all of the elements in the group.
    If you apply a transform node above the group, it will also transform other layers which we don't want.

    image

@TrueDoctor
Copy link
Member

TrueDoctor commented Mar 6, 2025

Only very few because we can use the automated edition upgrade on this pr as well. that should resolve most of the conficts - Edit wrong pr, meant to comment on #2367

@0HyperCube 0HyperCube force-pushed the instance-tables-pt5 branch from f9dbbc7 to 8684636 Compare March 8, 2025 22:32
@Keavon Keavon force-pushed the instance-tables-pt5 branch from ac7bbf9 to b220693 Compare March 10, 2025 23:17
@Keavon Keavon merged commit a696aae into master Mar 12, 2025
4 checks passed
@Keavon Keavon deleted the instance-tables-pt5 branch March 12, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tracking Issue: Instances tables

5 participants