Instance tables refactor part 2: move the transform and alpha_blending fields up a level #2249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Keavon
force-pushed
the
instance-tables-pt2
branch
from
5ab7d65 to
b4acfb8
Compare
Keavon
force-pushed
the
instance-tables-pt2
branch
from
b4acfb8 to
1d10a4e
Compare
Keavon
force-pushed
the
instance-tables-pt2
branch
from
211fc74 to
e9de2c8
Compare
Keavon
force-pushed
the
instance-tables-pt2
branch
from
297cb20 to
5c25935
Compare
Rename method one_item to one_instance
…eMut<T> Move the Instance<T> methods over to providing an Instance<T>/InstanceMut<T>
Keavon
force-pushed
the
instance-tables-pt2
branch
from
5c25935 to
f2a2c3c
Compare
Keavon
force-pushed
the
instance-tables-pt2
branch
from
f2a2c3c to
ad204fb
Compare
Keavon
force-pushed
the
instance-tables-pt2
branch
from
ad204fb to
f2e6944
Compare
Keavon
force-pushed
the
instance-tables-pt2
branch
from
f2e6944 to
793ffaa
Compare
Keavon
added a commit
that referenced
this pull request
Mar 6, 2025
…g fields up a level (#2249) * Fix domain data structure field plural naming * Rename method one_item to one_instance Rename method one_item to one_instance * Move the Instance<T> methods over to providing an Instance<T>/InstanceMut<T> Move the Instance<T> methods over to providing an Instance<T>/InstanceMut<T> * Add transform and alpha_blending fields to Instances<T> * Finish the refactor (Brush tool is broken though) * Add test for brush node * Fix brush node * Fix default empty images being 1x1 instead of 0x0 as they should be * Fix tests * Fix path transform * Add correct upgrading to move the transform/blending up a level --------- Co-authored-by: hypercube <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2, partly closes #1834
Currently based on commit 252de1b from #2232. The first commit in the chain of this PR's changes is 2fc5fb3. This PR is blocked on that PR being merged first.