STS Azure sample #7529
Merged
STS Azure sample #7529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JesseLovelace
requested review from
a team and
yoshi-approver
as code owners
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
product-auto-label
bot
added
the
samples
danielbankhead
approved these changes
Dec 28, 2022
Sita04
requested changes
Jan 4, 2023
...ansfer/src/main/java/com/google/cloud/storage/storagetransfer/samples/TransferFromAzure.java
Outdated
Show resolved
Hide resolved
...ansfer/src/main/java/com/google/cloud/storage/storagetransfer/samples/TransferFromAzure.java
Show resolved
Hide resolved
| // Create the transfer job | ||
| TransferJob response = | ||
| storageTransfer.createTransferJob( | ||
| TransferProto.CreateTransferJobRequest.newBuilder() |
Contributor
There was a problem hiding this comment.
Suggesting to inline the "TransferProto" to make it more readable.
Contributor
There was a problem hiding this comment.
Apologies if I wasn't clear enough. Could you include TransferProto.CreateTransferJobRequest in the import statement so that you could directly access CreateTransferJobRequest.newBuilder() in this line?
Comment on lines
67
to
68
| .setAzureCredentials(AzureCredentials.newBuilder() | ||
| .setSasToken(azureSasToken).build()) |
Contributor
There was a problem hiding this comment.
Kindly lint AzureCredentials:
.setAzureCredentials(AzureCredentials.newBuilder()
.setSasToken(azureSasToken)
.build())
.setContainer...
...ansfer/src/main/java/com/google/cloud/storage/storagetransfer/samples/TransferFromAzure.java
Outdated
Show resolved
Hide resolved
...ansfer/src/main/java/com/google/cloud/storage/storagetransfer/samples/TransferFromAzure.java
Show resolved
Hide resolved
...ansfer/src/main/java/com/google/cloud/storage/storagetransfer/samples/TransferFromAzure.java
Outdated
Show resolved
Hide resolved
...ansfer/src/main/java/com/google/cloud/storage/storagetransfer/samples/TransferFromAzure.java
Outdated
Show resolved
Hide resolved
Sita04
reviewed
Jan 6, 2023
|
|
||
| // Your Azure Storage Account name | ||
| String azureStorageAccountName = "myAzureAccountName"; | ||
| String azureStorageAccount = "myAzureAccoun"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a sample for transferring data from Azure