samples: refactor dialogflow for 2.1.0 #3283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
lesv
suggested changes
Jun 30, 2020
Contributor
lesv
left a comment
lesv
left a comment
There was a problem hiding this comment.
Consider my comments on Exceptions, ok to ignore, but it would be nice if we were more specific so users knew what to expect.
dialogflow/cloud-client/src/main/java/com/example/dialogflow/DetectIntentAudio.java
Outdated
Show resolved
Hide resolved
dialogflow/cloud-client/src/main/java/com/example/dialogflow/IntentManagement.java
Show resolved
Hide resolved
dialogflow/cloud-client/src/test/java/com/example/dialogflow/DetectIntentKnowledgeTest.java
Outdated
Show resolved
Hide resolved
Contributor
Author
Will this be sufficient? |
lesv
approved these changes
Jun 30, 2020
Shabirmean
pushed a commit
that referenced
this pull request
Nov 14, 2022
* samples: refactor dialogflow for 2.1.0 * formatted code * made requested changes * fixed compilation error * fixed lint on tests * lint issue
9 tasks
Shabirmean
pushed a commit
that referenced
this pull request
Nov 15, 2022
* samples: refactor dialogflow for 2.1.0 * formatted code * made requested changes * fixed compilation error * fixed lint on tests * lint issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3207
I will refactor IntentMgmt.java and break them down into individual files in different PR.