Skip to content

Rework the tests to remove flakiness (hopefully) #1488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 25, 2019
Merged

Rework the tests to remove flakiness (hopefully) #1488

merged 5 commits into from
Jun 25, 2019

Conversation

@nnegrey
Copy link
Contributor

@nnegrey nnegrey commented Jun 24, 2019 •
edited
Loading

Fix: #1480

@nnegrey nnegrey requested a review from a team June 24, 2019 22:43
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 24, 2019
@nnegrey
Copy link
Contributor Author

nnegrey commented Jun 25, 2019

Alright need to push another update.
The old tests delete all the Knowledge Bases and because the periodic tests ran, my test knowledge base was deleted. Going to create a new one, update the IDs then merge this quickly.

@nnegrey nnegrey merged commit 4408bd1 into master Jun 25, 2019
@nnegrey nnegrey deleted the flaky-test-fix branch June 25, 2019 14:53
Shabirmean pushed a commit that referenced this pull request Nov 14, 2022
@nnegrey @chingor13
samples: Rework the tests to remove flakiness (hopefully) (#1488)
00f7de4 
* Rework the tests to remove flakiness (hopefully)

* Update IDs since old test deleted my knowledge base
@Shabirmean Shabirmean mentioned this pull request Nov 15, 2022
Merged
9 tasks
Shabirmean pushed a commit that referenced this pull request Nov 15, 2022
@nnegrey @Shabirmean
samples: Rework the tests to remove flakiness (hopefully) (#1488)
fe8a874 
* Rework the tests to remove flakiness (hopefully)

* Update IDs since old test deleted my knowledge base
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lesv lesv lesv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flaky Dialogflow tests

4 participants

@nnegrey @lesv @googlebot