Skip to content

Conversation

@grant
Copy link
Contributor

@grant grant commented Dec 2, 2021

It looks like the doc CI check would not produce the right exit code. This should correctly report bad doc errors (see below).

  • Fixes docs CI error code
  • Runs docs CI

Signed-off-by: Grant Timmerman <[email protected]>
@grant grant self-assigned this Dec 2, 2021
@google-cla google-cla bot added the cla: yes label Dec 2, 2021
@grant grant changed the title ci: fix docs ci - bad ci: fix docs ci Dec 2, 2021
grant added 2 commits December 1, 2021 21:31
Signed-off-by: Grant Timmerman <[email protected]>
Signed-off-by: Grant Timmerman <[email protected]>
@grant
Copy link
Contributor Author

grant commented Dec 2, 2021

Ironically, docs CI failed for a different PR appropriately.

#400

I suspect this CI must not fail for certain changes. Anyways, I believe this CI change is more stable.

Copy link
Member

@matthewrobertson matthewrobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Grant Timmerman <[email protected]>
@grant grant added the automerge Summon MOG for automerging label Dec 2, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 2073558 into master Dec 2, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Summon MOG for automerging label Dec 2, 2021
@grant grant deleted the grant_docs_ci branch December 3, 2021 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants