Integration Firebase Functions #108

deekshithreddyr · 2019-07-10T19:01:53Z

No description provided.

googlebot · 2019-07-10T19:02:00Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

samples-refs_heads_mobile-auth-mobile-mobile_proxy_server-android_app/.gitignore

samples-refs_heads_mobile-auth-mobile-mobile_proxy_server-android_app/app/build.gradle

...fs_heads_mobile-auth-mobile-mobile_proxy_server-android_app/app/src/main/AndroidManifest.xml

...erver-android_app/app/src/main/java/com/example/mlapitest/utils/KnowledgebaseManagement.java

googlebot · 2019-07-16T00:10:53Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

dialoflow/.gitignore

dialoflow/README.md

dialoflow/app/src/main/java/com/google/cloud/examples/dialogflow/ui/ChatActivity.java

dialoflow/README.md

dialoflow/app/src/main/java/com/google/cloud/examples/dialogflow/ui/MainActivity.java

dialoflow/README.md

dialoflow/app/src/main/java/com/google/cloud/examples/dialogflow/ui/WelcomeActivity.java

dialoflow/app/src/main/res/values/strings.xml

dialoflow/app/src/main/java/com/google/cloud/examples/dialogflow/ui/WelcomeActivity.java

dialoflow/README.md

dialoflow/app/src/main/java/com/google/cloud/examples/dialogflow/ui/WelcomeActivity.java

dialoflow/app/src/main/java/com/google/cloud/examples/dialogflow/utils/KnowledgebaseUtils.java

dialogflow/app/src/main/java/com/google/cloud/examples/dialogflow/utils/ApiRequest.java

nnegrey · 2019-08-19T15:41:42Z

dialogflow/app/src/main/java/com/google/cloud/examples/dialogflow/ui/ChatActivity.java

        @Override
        protected void onPreExecute() {
            super.onPreExecute();
-            showProgressDialog();


With this line gone, you can remove the onPreExecute() method override now that we just use the default.

nnegrey · 2019-08-19T15:45:14Z

dialogflow/README.md

 - [Create a Service account](https://cloud.google.com/iam/docs/creating-managing-service-accounts) with the following IAM role: `Dialogflow API Client`. Example name: `dialogflow-client`. ([For more info on: how to add roles to a Service Account](https://cloud.google.com/iam/docs/granting-roles-to-service-accounts#granting_access_to_a_service_account_for_a_resource))
+- Under Dialogflow-client, Click on edit permission icon on the right and add another role as follows and save the changes:
+  - Dialogflow Client
+  - Dialogflow Reader


Ooo let's add a small note that sorta explains why we chose each Role.

- Dialogflow Client (Used by the app to make detect intent requests) - Dialogflow Reader (Used by the app to list knowledge bases)

nnegrey · 2019-08-19T17:55:59Z

Oh I forgot about this one, we need to add the LICENSE to the top of the java files.

/*
 * Copyright 2019 Google LLC
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

nnegrey · 2019-08-19T17:58:50Z

dialogflow/app/src/main/java/com/google/cloud/examples/dialogflow/ui/ChatActivity.java

+     */
+    private void showProgressDialog() {
+        AlertDialog.Builder builder = new AlertDialog.Builder(this);
+        builder.setMessage("Please wait...");


Nit: "Please wait..." --> "Fetching auth token..."

Thoughts?

…ocs-samples * 'master' of https://github.com/deekshithreddyr/android-docs-samples: Update README.md Update README.md

dialogflow/app/src/main/java/com/google/cloud/examples/dialogflow/utils/ApiRequest.java

nnegrey · 2019-08-28T22:27:33Z

I think my last 2 big things are:

If you can easily switch over to the streaming audio call for Dialogflow so as the user is speaking the audio is sent.
Take the really long lines and just make them multi line for code readability.
Example:
From 223 columns.

    private DetectIntentRequest getDetectIntentRequest(SessionName sessionName, QueryInput queryInput,boolean tts, boolean sentiment, boolean knowledge, FixedCredentialsProvider fixedCredentialsProvider) throws Exception {

To something under 100 columns.

    private DetectIntentRequest getDetectIntentRequest(
            SessionName sessionName, QueryInput queryInput,boolean tts, boolean sentiment,
            boolean knowledge, FixedCredentialsProvider fixedCredentialsProvider) throws Exception {

bdannoville · 2019-08-29T08:55:43Z

Hi there,
please note that at lign 50 of the readme, the link to the index.js containing nodeJS cloud functions for Dialogflow is broken. This file doesn't exist in the targeted github project: GoogleCloudPlatform/nodejs-docs-samples.

nnegrey · 2019-08-29T15:29:38Z

Updated link should be: https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/master/functions/tokenservice/functions/index.js

index.js Link update

…ocs-samples * 'master' of https://github.com/deekshithreddyr/android-docs-samples: Update README.md Code readability update

nnegrey · 2019-08-30T21:53:25Z

Speech2Speech/app/src/main/java/com/example/translate/AppController.java

+    public static void playAudio(byte[] byteArray) {
+        MediaPlayer mediaPlayer = new MediaPlayer();
+        try {
+            File tempFile = File.createTempFile("dialogFlow", null, Environment.getExternalStorageDirectory());


Rename temp file to speech2speech or something similar.

nnegrey · 2019-08-30T21:56:28Z

Speech2Speech/app/src/main/java/com/example/translate/adapter/LanguageAdapter.java

+    }
+
+    class Holder {
+        TextView text1;


Can text1 be a bit more descriptive?
Not sure of its purpose

nnegrey · 2019-09-03T16:18:52Z

Speech2Speech/app/src/main/java/com/example/translate/ui/MainActivity.java

+                getNewToken();
+            }
+        } else {
+            Toast.makeText(this, "Please enter or say some message to send.", Toast.LENGTH_SHORT).show();


NIT: Let's switch this to just Please enter a message

I tried with the voice and not saying anything and the audio already has a way to detect if nothing is said and they only press the send button when typing, where the audio is automatically sent.

nnegrey · 2019-09-03T16:50:26Z

Speech2Speech/app/src/main/java/com/example/translate/ui/SettingsActivity.java

+        setContentView(R.layout.activity_settings);
+
+        if (AppController.PROJECT_ID.equals("GCP_PROJECT_ID")) {
+            Toast.makeText(this, "Please update the GCP_PROJECT_ID in strings.xml", Toast.LENGTH_LONG).show();


Is there a way to have this toast happen but not shut down the app?

I forgot to update the strings.xml and took me a few openings to notice the toast message.

Side question that I don't know if it is possible, but can you retrieve the project id from the google-services.json file?
IF so, that would be neat.

nnegrey · 2019-09-03T16:53:09Z

Speech2Speech/.gitignore

@@ -0,0 +1,13 @@
+*.iml


Please add a README for speech to speech

nnegrey · 2019-09-03T16:57:07Z

Speech2Speech/app/src/main/java/com/example/translate/ui/SettingsActivity.java

+        protected void onPostExecute(List<Language> response) {
+            super.onPostExecute(response);
+            if (TextUtils.isEmpty(sourceLanguageCode)) {
+                sourceLanguageList.addAll(response);


I'm guessing this is me not having set up the correct permissions yet, but I got an error and crash.

java.lang.NullPointerException: Attempt to invoke interface method 'java.lang.Object[] java.util.Collection.toArray()' on a null object reference at java.util.ArrayList.addAll(ArrayList.java:588) at com.example.translate.ui.SettingsActivity$LanguageList.onPostExecute(SettingsActivity.java:304) at com.example.translate.ui.SettingsActivity$LanguageList.onPostExecute(SettingsActivity.java:283)

nnegrey · 2019-09-03T17:18:07Z

Speech2Speech/app/src/main/java/com/example/translate/utils/AuthUtils.java

+        Map<String, String> data = new HashMap<>();
+        data.put("deviceID", firebaseInstanceId);
+
+        FirebaseFunctions.getInstance()


After an hour or more. I got some weird message:

https://github.com/grpc/grpc-java/blob/master/auth/src/main/java/io/grpc/auth/GoogleAuthLibraryCallCredentials.java#L144-L146

nnegrey · 2019-09-16T17:43:15Z

Samples moved into multiple PRs:
#112
#113

Closing.

Initial commit

aa516b2

nnegrey reviewed Jul 10, 2019

View reviewed changes

samples-refs_heads_mobile-auth-mobile-mobile_proxy_server-android_app/.gitignore Show resolved Hide resolved

nnegrey reviewed Jul 10, 2019

View reviewed changes

samples-refs_heads_mobile-auth-mobile-mobile_proxy_server-android_app/app/build.gradle Outdated Show resolved Hide resolved

nnegrey reviewed Jul 10, 2019

View reviewed changes

samples-refs_heads_mobile-auth-mobile-mobile_proxy_server-android_app/app/build.gradle Outdated Show resolved Hide resolved

nnegrey reviewed Jul 10, 2019

View reviewed changes

...fs_heads_mobile-auth-mobile-mobile_proxy_server-android_app/app/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved

nnegrey reviewed Jul 10, 2019

View reviewed changes

...erver-android_app/app/src/main/java/com/example/mlapitest/utils/KnowledgebaseManagement.java Outdated Show resolved Hide resolved

Addressed review comments

ad096da

Added README File

2a0b27f