<howto-slider> #129
Closed
<howto-slider> #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just started reviewing :) |
Sent from
|
Hey @sendilkumarn thanks for sending this in! I'm in a meeting for most of tomorrow so it might take me a couple of days to do a full review but I've started looking into it. I'll follow up as soon as I can. |
|
I think the slider will need to support being dragged by the mouse. If you take a look at this example https://www.w3.org/TR/wai-aria-practices-1.1/examples/slider/slider-1.html I think they have the javascript example which shows how to implement that. |
Linting adding mouse events
sendilkumarn
force-pushed
the
howto-slider
branch
from
e0a10e2 to
9ec5355
Compare
|
I have done the mouse actions |
|
Just started reviewing :) |
|
Created a new PR to track this over in #131 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.