Don't install openssl
and gnu-sed
on macOS CI
#1986
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale:
For
openssl
, themacos-latest
image already has it, and the installation is currently (and has for some time been) a no-op:The workflow has attempted to install
openssl
explicitly viabrew
since a7db791 (#295). This was described as an effort to fix the build on macOS 11, and from context it looks like it was useful, and likely necessaryn at the time. Butmacos-latest
is currently macOS 14 or higher.More significantly,
openssl
on the macOS CI runners had been version 1.1, but it is version 3 since actions/runner-images#10851. The images seem to keep a current version. If that changes, then it might once again be a good idea to upgrade viabrew
, but might not.For
gnu-sed
, we are not using it. The executable was being set up on CI only asgsed
:But no references to
gsed
remain. Specifically, in #392,gsed
was used inmake_rebase_i_repo.sh
as of ac3c8c7. But it was removed in fc61c0d, which was later in that same PR. There have been no uses ofgsed
in this project since then.