-
Notifications
You must be signed in to change notification settings - Fork 4k
Fix bundling of @gitbook/expr
package
#3639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: def729c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's perfect, could you remove "src" from files in the package.json, it makes the package heavy for nothing. See https://www.npmjs.com/package/@gitbook/expr?activeTab=code
245kb for that is 🤯
Fix bundling of
@gitbook/expr
package so it can be friendlier with playwright and older node version.Aim to fix the import resolution issue encountered when the package is indirectly imported in playwright tests:
https://github.com/GitbookIO/gitbook-x/actions/runs/17589025313/job/50022307039