Skip to content

Conversation

spastorelli
Copy link
Contributor

Fix bundling of @gitbook/expr package so it can be friendlier with playwright and older node version.

Aim to fix the import resolution issue encountered when the package is indirectly imported in playwright tests:
https://github.com/GitbookIO/gitbook-x/actions/runs/17589025313/job/50022307039

Copy link

changeset-bot bot commented Sep 11, 2025

🦋 Changeset detected

Latest commit: def729c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@gitbook/expr Minor
@gitbook/react-openapi Patch
gitbook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

argos-ci bot commented Sep 11, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v2 (Inspect) 👍 Changes approved 3 changed Sep 11, 2025, 1:19 PM
v2-cloudflare (Inspect) 👍 Changes approved 1 changed Sep 11, 2025, 1:22 PM
v2-vercel (Inspect) 👍 Changes approved 2 changed Sep 11, 2025, 1:22 PM

Copy link
Contributor

@gregberge gregberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's perfect, could you remove "src" from files in the package.json, it makes the package heavy for nothing. See https://www.npmjs.com/package/@gitbook/expr?activeTab=code
245kb for that is 🤯

@spastorelli spastorelli merged commit e1ff17e into main Sep 11, 2025
16 checks passed
@spastorelli spastorelli deleted the steeve/fix-bundling-gitbook-expr branch September 11, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants