Skip to content

Conversation

BrettJephson
Copy link
Contributor

@BrettJephson BrettJephson commented Nov 29, 2024

Fix annoying inline whitespace thing when showing icons in section tabs.

Explainer - https://www.joshwcomeau.com/css/understanding-layout-algorithms/#inline-magic-space-5

After fix (tab section same height with and without icons):
Screenshot 2024-11-29 at 16 41 04

Before fix (adding some random whitespace):
Screenshot 2024-11-29 at 16 40 01

@BrettJephson BrettJephson self-assigned this Nov 29, 2024
Copy link

changeset-bot bot commented Nov 29, 2024

⚠️ No Changeset found

Latest commit: cbdb143

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@BrettJephson BrettJephson marked this pull request as ready for review November 29, 2024 16:44
Copy link
Contributor

github-actions bot commented Nov 29, 2024

GitBook Preview
Latest commit: https://c01538a8.gitbook-open.pages.dev
PR: https://pr2594.gitbook-open.pages.dev

Copy link

argos-ci bot commented Nov 29, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 5 changed Nov 29, 2024, 4:52 PM

@BrettJephson BrettJephson merged commit 2ce59d7 into main Nov 29, 2024
9 checks passed
@BrettJephson BrettJephson deleted the brett/fix-added-whitespace-tabs branch November 29, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants