Skip to content

Conversation

zenoachtig
Copy link
Contributor

Links inside hint blocks correctly change their color to match the hint block, but the text-decoration property is not changed with them. Let’s fix that by making them inherit their text color properly.

Preview

Screenshot 2024-11-27 at 20 59 41

Copy link

changeset-bot bot commented Nov 27, 2024

⚠️ No Changeset found

Latest commit: aed49ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 27, 2024

GitBook Preview
Latest commit: https://4cf66dd0.gitbook-open.pages.dev
PR: https://pr2590.gitbook-open.pages.dev

Copy link

argos-ci bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 12 changed Nov 29, 2024, 3:24 PM

Copy link
Contributor

@BrettJephson BrettJephson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Do we not want to keep the slightly lighter (or semi-transparent) effect on the text decoration?

@zenoachtig
Copy link
Contributor Author

Looks good.

Do we not want to keep the slightly lighter (or semi-transparent) effect on the text decoration?

Yeah upon second look you’re right, I’ve added the semi-transparent decoration style to the hint blocks after all. The default one inherits from the default link style, which includes it.

@zenoachtig zenoachtig merged commit f2a467f into main Nov 29, 2024
9 checks passed
@zenoachtig zenoachtig deleted the zeno/hint-decoration-color branch November 29, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants