Skip to content

Fix canonical URL ending with "/" #2586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2024
Merged

Fix canonical URL ending with "/" #2586

merged 1 commit into from
Nov 26, 2024

Conversation

gregberge
Copy link
Contributor

No description provided.

@linear Linear
Copy link

linear bot commented Nov 26, 2024

RND-5559 Set consistent trailing slash in canonical URLs

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 26, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3d2d309

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gregberge gregberge requested a review from SamyPesse November 26, 2024 15:55
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 26, 2024 •
edited
Loading

GitBook Preview
Latest commit: https://e49805aa.gitbook-open.pages.dev
PR: https://pr2586.gitbook-open.pages.dev

@argos-ci Argos CI
Copy link

argos-ci bot commented Nov 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 10 changed Nov 26, 2024, 8:52 PM

SamyPesse
SamyPesse reviewed Nov 26, 2024
View reviewed changes
@gregberge gregberge force-pushed the greg/rnd-5559-set-consistent-trailing-slash-in-canonical-urls branch from b231adf to eee9d6e Compare November 26, 2024 17:15
@gregberge gregberge requested a review from SamyPesse November 26, 2024 17:16
SamyPesse
SamyPesse approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@SamyPesse SamyPesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge like this to unblock, even if it looks lost and we'll probably soon forget why it's here

@gregberge
Copy link
Contributor Author

Feel free to merge like this to unblock, even if it looks lost and we'll probably soon forget why it's here

I will comment it.

@gregberge gregberge force-pushed the greg/rnd-5559-set-consistent-trailing-slash-in-canonical-urls branch from eee9d6e to b868ecb Compare November 26, 2024 20:44
@gregberge gregberge force-pushed the greg/rnd-5559-set-consistent-trailing-slash-in-canonical-urls branch from b868ecb to 3d2d309 Compare November 26, 2024 20:46
@gregberge gregberge merged commit 28f1ed9 into main Nov 26, 2024
9 checks passed
@gregberge gregberge deleted the greg/rnd-5559-set-consistent-trailing-slash-in-canonical-urls branch November 26, 2024 20:57
spastorelli added a commit that referenced this pull request Nov 27, 2024
@spastorelli
Revert "Fix canonical URL ending with "/" (#2586)"
d11973d 
This reverts commit 28f1ed9.
spastorelli added a commit that referenced this pull request Nov 27, 2024
@spastorelli
Revert "Fix canonical URL ending with "/" (#2586)" (#2588)
fc8065b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SamyPesse SamyPesse SamyPesse approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gregberge @SamyPesse