-
Notifications
You must be signed in to change notification settings - Fork 663
Mainline development mode #950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mainline development mode #950
Conversation
|
The branching strategy images still contain |
src/GitVersionCore/AssemblyInfo.cs
Outdated
| [assembly: AssemblyProduct("GitVersion")] | ||
| [assembly: AssemblyVersion("1.0.0")] | ||
| [assembly: AssemblyFileVersion("1.0.0")] | ||
| [assembly: AssemblyVersion("4.0.0.0")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this set through GitVersion in the build process and should be kept to 1.0.0 in the repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran build script locally, forgot to reset these changes
|
We should also make sure to document the new mainline mode properly. There is already a mainline documentation available which should be updated with these changes. |
cba2bf7 to
defc31b
Compare
docs/versioning-mode.md
Outdated
| As such we force a pre-release tag on all branches, this is fine for applications but can cause problems for libraries. As such this mode may or may not work for you, which leads us into a new mode in v4. Mainline development. | ||
|
|
||
| ## Mainline development | ||
| Mainline development works more like the Continuous Delivery mode, except that it tells GitVersion to *infer* releases from from event. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: from from
|
I did a local build and tried it out, worked great and as expected during my quick testing. My 🍠 I did get two test failures though when running build.ps1: |
This builds on top of #832
It's pretty rough but will ship this as part of 4.0.0 beta if it looks ok