Skip to content

Fix argument parsing #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2016
Merged

Fix argument parsing #867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9f2c95
Ignore - and / for switches when determine if they are boolean arguments
May 18, 2016
86bfac3
Add test case
May 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/GitVersionExe.Tests/ArgumentParserTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,4 +291,12 @@ public void log_path_can_contain_forward_slash()
var arguments = ArgumentParser.ParseArguments("-l /some/path");
arguments.LogFilePath.ShouldBe("/some/path");
}

[Test]
public void boolean_argument_handling()
{
var arguments = ArgumentParser.ParseArguments("/nofetch /updateassemblyinfo true");
arguments.NoFetch.ShouldBe(true);
arguments.UpdateAssemblyInfo.ShouldBe(true);
}
}
2 changes: 1 addition & 1 deletion src/GitVersionExe/ArgumentParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ static bool IsBooleanArgument(string switchName)
"nofetch"
};

return booleanArguments.Contains(switchName, StringComparer.OrdinalIgnoreCase);
return booleanArguments.Contains(switchName.Substring(1), StringComparer.OrdinalIgnoreCase);
}
}
}