Skip to content

Conversation

@taborda
Copy link

@taborda taborda commented Mar 31, 2016

…lease branch in continuous deployment mode

Tests behavior seen in #814

…lease branch in continuous deployment mode
@asbjornu
Copy link
Member

@taborda Thanks for this! However, git rev-list --count master shows that this PR is now 1730 commits behind master. Could you please do a rebase and ensure that the test fails the same way afterwards? The EmptyRepositoryFixture being used is no longer included in GitVersion, but from GitTools.Testing, so it might behave a bit differently (it doesn't take a Config parameter, for instance).

@asbjornu
Copy link
Member

asbjornu commented May 25, 2016

@taborda Great! But can you please rebase (not merge) on master so it gets the fixes in #876 that ensures the Travis build is run? The easiest way to do this in a tidy way would probably be to do:

git checkout ReleaseBranchMergeCountReset
git branch ReleaseBranchMergeCountReset-Backup
git reset --hard upstream/master
git cherry-pick -n 64b40bb936f3ba4403123d55bae4f8a24aabf966
git cherry-pick -e 735cf8a31344cc352f31e5b5293c783947cb8d65

This way you get to the HEAD of master in upstream (i.e. this repository) with the valuable commits in this PR. If you make a mistake, you can always reset back to ReleaseBranchMergeCountReset-Backup created on line 2.

Please just ask here or on Gitter if you have any problems or questions!

JakeGinnivan added a commit to JakeGinnivan/GitVersion that referenced this pull request Jul 10, 2016
…e branch commit counts are reset incorrectly)
@JakeGinnivan
Copy link
Contributor

Verify #832 fixes this by pulling this test in to that branch

JakeGinnivan added a commit to JakeGinnivan/GitVersion that referenced this pull request Jul 10, 2016
…e branch commit counts are reset incorrectly)
JakeGinnivan added a commit to JakeGinnivan/GitVersion that referenced this pull request Jul 16, 2016
…e branch commit counts are reset incorrectly)
JakeGinnivan added a commit to JakeGinnivan/GitVersion that referenced this pull request Jul 17, 2016
…e branch commit counts are reset incorrectly)
@taborda taborda deleted the ReleaseBranchMergeCountReset branch August 16, 2016 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants