Skip to content

Set System.Collections.Immutable as a private asset #4594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025
Merged

Set System.Collections.Immutable as a private asset #4594

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/GitVersion.MsBuild/GitVersion.MsBuild.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
<PackageReference Include="Microsoft.Build.Utilities.Core" />
<PackageReference Include="Microsoft.Win32.Registry" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection" />
<PackageReference Include="System.Collections.Immutable" />
Copy link

Copilot AI Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The current reference for System.Collections.Immutable is added without an explicit PrivateAssets attribute. Although the global update applies PrivateAssets to all PackageReferences, adding a comment here to explain this behavior could enhance code clarity.

Suggested change
<PackageReference Include="System.Collections.Immutable" />
<PackageReference Include="System.Collections.Immutable" PrivateAssets="All" />
<!-- Explicitly specifying PrivateAssets="All" here for clarity, even though the global update applies it to all PackageReferences. -->

Copilot uses AI. Check for mistakes.
<!-- Marks all packages as 'local only' so they don't end up in the nuspec. -->
<PackageReference Update="@(PackageReference)" PrivateAssets="All"/>
<PackageReference Include="System.Collections.Immutable" />
</ItemGroup>

<ItemGroup>
Expand Down