Skip to content

Conversation

vinnyrose
Copy link
Contributor

@vinnyrose vinnyrose commented Jul 31, 2024

Description

Replace underscores in branch specific labels that may have been included through regex group matches.

Related Issue

#4110

Motivation and Context

The underscore is outputted into the SemVer value and elsewhere, but underscores are not valid SemVer characters.

How Has This Been Tested?

Added integration test case.

Screenshots (if appropriate):

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@arturcic arturcic linked an issue Jul 31, 2024 that may be closed by this pull request
2 tasks
@arturcic arturcic enabled auto-merge July 31, 2024 17:48
@arturcic arturcic self-requested a review July 31, 2024 17:48
@arturcic arturcic merged commit 0fd23d1 into GitTools:main Jul 31, 2024
@vinnyrose vinnyrose deleted the feature/underscore-label-fix branch July 31, 2024 17:55
Copy link
Contributor

mergify bot commented Jul 31, 2024

Thank you @vinnyrose for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE]: dotnet publish: '0.0.1-abc_def.1+1' is not a valid version string GitVersion.MSBuild with Packable .NET 8 project does not get valid SemVer
2 participants