Include missing env var in Buildkite docs #3045
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [Buildalyzer](https://github.com/daveaglick/Buildalyzer) from 3.2.2 to 4.1.2. - [Release notes](https://github.com/daveaglick/Buildalyzer/releases) - [Changelog](https://github.com/daveaglick/Buildalyzer/blob/main/RELEASE.md) - [Commits](Buildalyzer/Buildalyzer@v3.2.2...v4.1.2) --- updated-dependencies: - dependency-name: Buildalyzer dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
asbjornu
requested changes
Mar 11, 2022
Member
There was a problem hiding this comment.
Hm, the change of target branch from main to release/5.x brought with it commits 7b0e243, 5c9e137 and 68ff363. Can you please reset your branch to HEAD of release/5.x and cherry-pick ffdf54a onto it, @santhonisz?
We should probably clarify the branch target in the PR template, @arturcic. We also need to adjust the docs publishing from release/5.x before this PR is merged.
Member
|
Closing in favor of #3077 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This expands the existing documentation for the Buildkite build server to include the additional required env var for running in Docker from the changes added in #3013
Related Issue
#3012
Motivation and Context
End users will typically be unaware of the required env vars when running in Docker, which will lead to failure to determine the correct version on PRs as per the original issue.
Checklist: