#2268 Correct a version calculation for non-master mainline branches #2269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kirill-Maurin
force-pushed
the
bugfix/2268
branch
4 times, most recently
from
4051a6f to
fc2bb64
Compare
asbjornu
approved these changes
May 11, 2020
Kirill-Maurin
force-pushed
the
bugfix/2268
branch
from
9029fe3 to
62b77cd
Compare
asbjornu
requested changes
May 12, 2020
Member
asbjornu
left a comment
asbjornu
left a comment
There was a problem hiding this comment.
Just a simple typo. Otherwise this is good to go. :)
src/GitVersionCore.Tests/IntegrationTests/MainlineDevelopmentMode.cs
Outdated
Show resolved
Hide resolved
Kirill-Maurin
force-pushed
the
bugfix/2268
branch
from
62b77cd to
2a5064e
Compare
Kirill-Maurin
force-pushed
the
bugfix/2268
branch
from
2a5064e to
1d254c3
Compare
Contributor
Author
Done |
asbjornu
approved these changes
May 12, 2020
Member
|
@Kirill-Maurin, looking good! Do you want to do a rebase or should I just merge from master? |
Member
|
@asbjornu let's merge it and we can release 5.3.3 |
Member
|
Thank you for your contributions, @Kirill-Maurin! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2268