Remove --privileged #17
Merged
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinbackhouse
requested review from
JarLob,
anticomputer,
m-y-mo and
p-
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR removes the --privileged flag from the devcontainer configuration, following changes made in PR #13 that apparently eliminated the need for privileged container access.
- Removes the
--privilegedDocker run argument from devcontainer configuration
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
50
to
52
| "runArgs": [ | ||
| "--privileged", | ||
| "--init" | ||
| ] |
There was a problem hiding this comment.
Removing the --privileged flag improves container security by following the principle of least privilege. However, ensure that any functionality that previously required privileged access (such as Docker-in-Docker operations) still works correctly with the current configuration.
m-y-mo
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think we need this anymore, after #13.
cc: @Kwstubbs