Skip to content

Bump minimum supported version to pyarrow>=16 #3917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2025
Merged

Bump minimum supported version to pyarrow>=16 #3917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18e3de9
Bump minimum supported version to pyarrow>=16
seisman Apr 16, 2025
a29c377
Merge branch 'main' into pyarrow-16
seisman Apr 16, 2025
a2ca3f1
Remove the dummy pyarrow version
seisman Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci_tests_legacy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ jobs:
contextily=1.5
geopandas=1.0
ipython
pyarrow-core
pyarrow-core=16
rioxarray
sphinx-gallery
make
Expand Down
2 changes: 1 addition & 1 deletion environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ dependencies:
- contextily>=1.5
- geopandas>=1.0
- ipython
- pyarrow-core
- pyarrow-core>=16
- rioxarray
# Development dependencies (general)
- dvc
Expand Down
11 changes: 1 addition & 10 deletions pygmt/tests/test_clib_to_numpy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ class pa: # noqa: N801
A dummy class to mimic pyarrow.
"""

__version__ = "0.0.0"

@staticmethod
def timestamp(unit: str, tz: str | None = None):
"""
Expand Down Expand Up @@ -625,14 +623,7 @@ def test_to_numpy_pyarrow_numeric_with_na(dtype, expected_dtype):
"utf8", # alias for string
"large_string",
"large_utf8", # alias for large_string
pytest.param(
"string_view",
# TODO(pyarrow>=16): Remove the skipif marker for pyarrow<16.
marks=pytest.mark.skipif(
Version(pa.__version__) < Version("16"),
reason="string_view type was added since pyarrow 16",
),
),
"string_view",
Copy link
Member

@weiji14 weiji14 Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also delete L27 __version__ = "0.0.0" added in #3660.

],
)
def test_to_numpy_pyarrow_string(dtype):
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ all = [
"contextily>=1.5",
"geopandas>=1.0",
"IPython", # 'ipython' is not the correct module name.
"pyarrow",
"pyarrow>=16",
"rioxarray",
]

Expand Down
Loading